-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example/facebook pixel script #34417
Merged
kodiakhq
merged 11 commits into
vercel:canary
from
lukeshumard:example/facebook-pixel-script-id
May 13, 2022
Merged
Example/facebook pixel script #34417
kodiakhq
merged 11 commits into
vercel:canary
from
lukeshumard:example/facebook-pixel-script-id
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeshumard
requested review from
timneutkens,
ijjk,
shuding,
leerob and
steven-tey
as code owners
February 16, 2022 16:46
Auta1994
reviewed
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sani
balazsorban44
approved these changes
May 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The with-facebook-pixel example attempts to run the <Script /> loading the Facebook Pixel on every request. This results in a warning stating
[Meta Pixel] - Duplicate Pixel ID: xxx
. According to the Next.js docs, by using an id on the inline script Next is able to track and optimize the script. Since this is absent on the present example, the inline script is continuously loaded on every request.I've added an id to this inline script, and the warning from facebook is no longer present.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint